- Make a Bugzilla account at bugs.webkit.org.
Tools/Scriptsto your shell path so scripts are easy to run.
- Update your build by running
- Make sure the problem you’re fixing still exists by running
For step by step instructions see Creating Layout Tests.
- See the documentation on running tests, writing new tests, and Writing Layout Tests for DumpRenderTree
run-webkit-teststo see if your bug fix fixes an existing broken testcase. (If it breaks a test that passed before, be sure your fix is correct before submitting it.)
- Otherwise, create a new testcase.
- It’s also possible to create a testcase that produces a PNG file and checksum to be compared with an expected result, if you’re testing things like colors. For example, see
fast/dom/css-rule-functions.html. For that, be sure not to use
- Create the expected result file(s).
- If your fix fixes an existing test (or breaks one, but you’re certain it’s correct), delete the existing expected result(s) for that test so a new expected result can be generated.
- Run your new test(s). To run only a subset of the full test suite, run
run-webkit-testswith the paths of the test directories or files relative to your
LayoutTestsdirectory. For example,
run-webkit-tests fast/dom/HTMLSelectElement/will run all the tests in that directory. If you want to generate PNGs and checksum files too, add the
- After the tests are done, the test system will launch your newly built Safari and offer to show the actual results of any tests that have no expected results, as well as diffs of the expected and actual results when applicable. It will automatically create the expected result files for any new tests, so look at their results and make sure they’re correct.
- If you need to make further changes, you can remove an expected result file and re-run its test to generate a new one. Or, you can run the test with the old expected results in place, and copy the new actual result from /tmp to the correct expected result file. (Don’t just copy and paste from the window, because it’s hard to make sure that all the whitespace is exactly right.)
- When you’re happy with the expected result, run the test again to be sure it now passes.
- Ensure your environment is prepared with
- Find, or file, an appropriate bug for your patch in Bugzilla, following the bug-reporting guidelines.
- See the WebKit guide to contributing code.
git addany files you’re modifying or adding.
git-webkit prto create a pull request for your changes.
- Edit the commit message template to add the bug reference(s) and brief descriptions for each change, following the examples in the template.
- You will receive a URL for your pull request in the output.